Update service_container.rst #18790
Closed
Update service_container.rst #18790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I think there was a mistake in the method name. I think it must be renamed to `formatMessage()`
| @@ -1420,7 +1420,7 @@ You also have a service that defines many methods and one of them is the same | |||
| { | |||
| // other methods... | |||
|
|
|||
| public function format($string $message, array $parameters): string | |||
| public function formatMessage($string $message, array $parameters): string | |||
There was a problem hiding this comment.
Maybe I'm missing something, but the method is called format() in the interface. So, the current text looks good to me. Could you please elaborate about why should we change this? Thanks!
There was a problem hiding this comment.
Hi, I have noticed also something wrong in the docs. I would rather to change the name of the function in the parameter of the AutowireCallable than the name of the function in the class MessageUtils (and therefore in the interface).
There was a problem hiding this comment.
Hello, I have done the changes in this PR : #19076
amelielecoz
added a commit
to amelielecoz/symfony-docs
that referenced
this pull request
Oct 23, 2023
Changes in response to my comment on this PR symfony#18790
|
Closing as fixed in #19076. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I think there was a mistake in the method name. I think it must be renamed to
formatMessage()